Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Datacatalog cache deletion #4655

Open
wants to merge 69 commits into
base: master
Choose a base branch
from

merge master

9e322a8
Select commit
Loading
Failed to load commit list.
Open

[Feature] Datacatalog cache deletion #4655

merge master
9e322a8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 12, 2024 in 0s

59.07% (+0.07%) compared to e07084c

View this Pull Request on Codecov

59.07% (+0.07%) compared to e07084c

Details

Codecov Report

Attention: Patch coverage is 67.56098% with 133 lines in your changes are missing coverage. Please review.

Project coverage is 59.07%. Comparing base (e07084c) to head (9e322a8).

Files Patch % Lines
flyteadmin/pkg/manager/impl/cache_manager.go 68.18% 65 Missing and 5 partials ⚠️
datacatalog/pkg/repositories/gormimpl/artifact.go 75.92% 9 Missing and 4 partials ⚠️
flytestdlib/catalog/client.go 0.00% 11 Missing ⚠️
flytestdlib/catalog/datacatalog/transformer.go 0.00% 10 Missing ⚠️
flytestdlib/catalog/noop_catalog.go 0.00% 10 Missing ⚠️
...atacatalog/pkg/manager/impl/reservation_manager.go 0.00% 5 Missing and 2 partials ⚠️
datacatalog/pkg/manager/impl/artifact_manager.go 88.00% 5 Missing and 1 partial ⚠️
flytestdlib/catalog/datacatalog/datacatalog.go 87.23% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4655      +/-   ##
==========================================
+ Coverage   59.00%   59.07%   +0.07%     
==========================================
  Files         645      647       +2     
  Lines       55578    55972     +394     
==========================================
+ Hits        32792    33065     +273     
- Misses      20194    20301     +107     
- Partials     2592     2606      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov