Skip to content

Commit

Permalink
switch order of keys
Browse files Browse the repository at this point in the history
Signed-off-by: Yini <[email protected]>
  • Loading branch information
yini7777 committed Mar 25, 2024
1 parent aca862f commit 759bf3d
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -298,13 +298,13 @@ deployRedoc: false

secrets:
adminOauthClientCredentials:
# If mount is true, helm will mount `flyte-secret-auth`.
# If mount is false, helm will not mount `flyte-secret-auth`.
# If create is true, helm will create the `flyte-secret-auth`.
# If create is false, it's up to the user to create `flyte-secret-auth` as described in
# https://docs.flyte.org/en/latest/deployment/cluster_config/auth_setup.html#oauth2-authorization-server
mount: true
# If mount is true, helm will mount `flyte-secret-auth`.
# If mount is false, helm will not mount `flyte-secret-auth`.
create: true
mount: true
clientSecret: "<>" # put the secret for the confidential client flytepropeller defined in the IDP
clientId: "flytepropeller" #use this client id and secret in the flytectl config with ClientSecret option

Expand Down
6 changes: 3 additions & 3 deletions charts/flyte-core/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -430,13 +430,13 @@ deployRedoc: false

secrets:
adminOauthClientCredentials:
# If mount is true, helm will mount `flyte-secret-auth`.
# If mount is false, helm will not mount `flyte-secret-auth`.
# If create is true, helm will create the `flyte-secret-auth`.
# If create is false, it's up to the user to create `flyte-secret-auth` as described in
# https://docs.flyte.org/en/latest/deployment/cluster_config/auth_setup.html#oauth2-authorization-server
mount: true
# If mount is true, helm will mount `flyte-secret-auth`.
# If mount is false, helm will not mount `flyte-secret-auth`.
create: true
mount: true
clientSecret: foobar
clientId: flytepropeller

Expand Down
12 changes: 6 additions & 6 deletions docs/deployment/configuration/auth_setup.rst
Original file line number Diff line number Diff line change
Expand Up @@ -345,13 +345,13 @@ Apply OIDC Configuration
secrets:
adminOauthClientCredentials:
# If mount is true, helm will mount `flyte-secret-auth`.
# If mount is false, helm will not mount `flyte-secret-auth`.
# If create is true, helm will create the `flyte-secret-auth`.
# If create is false, it's up to the user to create `flyte-secret-auth` as described in
# https://docs.flyte.org/en/latest/deployment/cluster_config/auth_setup.html#oauth2-authorization-server
mount: true
# If mount is true, helm will mount `flyte-secret-auth`.
# If mount is false, helm will not mount `flyte-secret-auth`.
create: true
mount: true
# Use the non-encoded version of the random password
clientSecret: "<your-random-password>"
clientId: flytepropeller
Expand Down Expand Up @@ -601,8 +601,8 @@ Follow the steps in this section to configure `flyteadmin` to use an external au
secrets:
adminOauthClientCredentials:
mount: true
create: true # see the section "Disable Helm secret management" if you require to do so
mount: true
# Replace with the client_secret provided by your IdP for flytepropeller.
clientSecret: <client_secret>
# Replace with the client_id provided by provided by your IdP for flytepropeller.
Expand All @@ -621,8 +621,8 @@ Follow the steps in this section to configure `flyteadmin` to use an external au
secrets:
adminOauthClientCredentials:
mount: true
create: true
mount: true
clientSecret: <client secret>
clientId: <client id>
---
Expand Down Expand Up @@ -679,8 +679,8 @@ Alternatively, you can instruct Helm not to create and manage the secret for ``f
secrets:
adminOauthClientCredentials:
mount: true # mount the flyte-secret-auth secret to the flytepropeller.
create: false # set to false
mount: true # mount the flyte-secret-auth secret to the flytepropeller.
# Replace with the client_id provided by provided by your IdP for flytepropeller.
clientId: <client_id>
Expand Down

0 comments on commit 759bf3d

Please sign in to comment.