Fix uploading of code coverage data (#5298)

* Do not upload codecoverage data from boilerplate Signed-off-by: Eduardo Apolinario <[email protected]> * Use correct token to upload code coverage data Signed-off-by: Eduardo Apolinario <[email protected]> * Pipe in CODECOV_TOKEN as an input secret Signed-off-by: Eduardo Apolinario <[email protected]> * Actually pipe the secret in Signed-off-by: Eduardo Apolinario <[email protected]> * Pipe codecov token in flyteidl tests too --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
flyteorg · Apr 29, 2024 · 6ebcb86 · 6ebcb86
1 parent f32132b
commit 6ebcb86
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 11 deletions.
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
@@ -61,7 +61,7 @@ jobs:
       component: ${{ matrix.component }}
       go-version: ${{ needs.unpack-envvars.outputs.go-version }}
     secrets:
-      FLYTE_BOT_PAT: ${{ secrets.FLYTE_BOT_PAT }}
+      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
   docker-build:
     strategy:
       fail-fast: false

diff --git a/.github/workflows/flyteidl-checks.yml b/.github/workflows/flyteidl-checks.yml
@@ -39,7 +39,7 @@ jobs:
       component: flyteidl
       go-version: ${{ needs.unpack-envvars.outputs.go-version }}
     secrets:
-      FLYTE_BOT_PAT: ${{ secrets.FLYTE_BOT_PAT }}
+      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
   generate:
     name: Check Go Generate
     needs:

diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
@@ -10,7 +10,7 @@ on:
         required: true
         type: string
     secrets:
-      FLYTE_BOT_PAT:
+      CODECOV_TOKEN:
         required: true
 jobs:
   tests:
@@ -27,15 +27,11 @@ jobs:
         with:
           go-version: ${{ inputs.go-version }}
       - name: Unit Tests
-        env:
-          GITHUB_TOKEN: ${{ secrets.FLYTE_BOT_PAT }}
         run: make install && make test_unit_codecov
-      # TODO(monorepo): Figure out how to do code coverage aggregation
       - name: Push CodeCov
-        uses: codecov/[email protected]
-        env:
-          GITHUB_TOKEN: ${{ secrets.FLYTE_BOT_PAT }}
+        uses: codecov/codecov-action@v4
         with:
           file: coverage.txt
-          flags: unittests
+          flags: unittests-${{ inputs.component }}
           fail_ci_if_error: false
+          token: ${{ secrets.CODECOV_TOKEN }}
diff --git a/boilerplate/flyte/golang_test_targets/Makefile b/boilerplate/flyte/golang_test_targets/Makefile
@@ -54,7 +54,6 @@ test_unit_visual:
 .PHONY: test_unit_codecov
 test_unit_codecov:
 	go test ./... -race -coverprofile=coverage.txt -covermode=atomic
-	curl -s https://codecov.io/bash > codecov_bash.sh && bash codecov_bash.sh
 
 .PHONY: go-tidy
 go-tidy: