add 'create' key for adminOauthClientCredentials

flyteorg · Mar 15, 2024 · 6290a63 · 6290a63
1 parent 3100c12
commit 6290a63
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/charts/flyte-core/templates/common/secret-auth.yaml b/charts/flyte-core/templates/common/secret-auth.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.secrets.adminOauthClientCredentials.enabled }}
+{{- if .Values.secrets.adminOauthClientCredentials.create }}
 apiVersion: v1
 kind: Secret
 metadata:

diff --git a/charts/flyte-core/values.yaml b/charts/flyte-core/values.yaml
@@ -430,10 +430,13 @@ deployRedoc: false
 
 secrets:
   adminOauthClientCredentials:
-    # -- If enabled is true, helm will create and manage `flyte-secret-auth` and populate it with `clientSecret`.
-    # If enabled is false, it's up to the user to create `flyte-secret-auth` as described in
+    # -- If enabled is true, helm will populate `flyte-secret-auth` with `clientSecret`.
+    # If enabled is false, helm will not populate `flyte-secret-auth`.
+    # If create is true, helm will create the `flyte-secret-auth`.
+    # If create is false, it's up to the user to create `flyte-secret-auth` as described in
     # https://docs.flyte.org/en/latest/deployment/cluster_config/auth_setup.html#oauth2-authorization-server
     enabled: true
+    create: true
     clientSecret: foobar
     clientId: flytepropeller