Skip to content

Commit

Permalink
Add multi file error aggregation strategy
Browse files Browse the repository at this point in the history
  • Loading branch information
bgedik committed Oct 9, 2024
1 parent 8f4629f commit 2df9e4d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ type pytorchOperatorResourceHandler struct {
var _ k8s.Plugin = pytorchOperatorResourceHandler{}

func (pytorchOperatorResourceHandler) GetProperties() k8s.PluginProperties {
return k8s.PluginProperties{}
return k8s.PluginProperties{
ErrorAggregationStrategy: k8s.EarliestErrorAggregationStrategy,
}
}

// Defines a func to create a query object (typically just object and type meta portions) that's used to query k8s
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,9 @@ func TestGetLogsElastic(t *testing.T) {

func TestGetProperties(t *testing.T) {
pytorchResourceHandler := pytorchOperatorResourceHandler{}
expected := k8s.PluginProperties{}
expected := k8s.PluginProperties{
ErrorAggregationStrategy: k8s.EarliestErrorAggregationStrategy,
}
assert.Equal(t, expected, pytorchResourceHandler.GetProperties())
}

Expand Down

0 comments on commit 2df9e4d

Please sign in to comment.