Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Deletion of artifacts #87

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MorpheusXAUT
Copy link
Contributor

TL;DR

This PR implements deletion of artifacts from datacatalog's database as well as underlying blob storage.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Datacatalog now supports deletion of artifacts (either via tag or artifact ID), removing the entry from the DB as well as underlying blob storage. Additional prometheus metrics for deletion have been added as well.
This is required for evicting the cache of past executions via flyteadmin.

The PR was created as a draft until the flyteidl and flytestdlib PRs have been merged and respective versions have been published.

Tracking Issue

flyteorg/flyte#2867

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #87 (51ccd78) into master (faa86db) will increase coverage by 1.24%.
The diff coverage is 82.02%.

❗ Current head 51ccd78 differs from pull request most recent head 2e80fba. Consider uploading reports for the commit 2e80fba to get more accurate results

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   68.41%   69.66%   +1.24%     
==========================================
  Files          31       31              
  Lines        1656     1744      +88     
==========================================
+ Hits         1133     1215      +82     
- Misses        445      448       +3     
- Partials       78       81       +3     
Flag Coverage Δ
unittests 69.66% <82.02%> (+1.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repositories/gormimpl/artifact.go 82.03% <79.54%> (-0.90%) ⬇️
pkg/manager/impl/artifact_manager.go 73.91% <84.44%> (+4.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MorpheusXAUT MorpheusXAUT force-pushed the cache-eviction-delete-artifact branch from 51ccd78 to 2e80fba Compare January 19, 2023 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant