Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[wip] Tag Stealing #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[wip] Tag Stealing #22

wants to merge 4 commits into from

Conversation

chanadian
Copy link
Contributor

No description provided.

@chanadian chanadian force-pushed the tag-stealing branch 2 times, most recently from 267a75c to 3893716 Compare February 10, 2020 19:34
@kumare3
Copy link
Contributor

kumare3 commented Mar 5, 2021

@chanadian do you mind describing this in some detail so that we can take over? what was the aim?

@chanadian
Copy link
Contributor Author

This was meant to solve the issue: flyteorg/flyte#118 (comment)

In Flyte it would help re-assign the label for the cache to a new artifact. In the PR, instead of using GORM to create the artifact, it would in a transaction:

  1. Find the set of partitions this artifact belongs to
  2. List artifacts in the partitions that are currently tagged with the tag
  3. Remove the tags from the currently tagged artifacts
  4. Add the artifact with the tag (or bring an identical tombstoned one back)

I don't think it was a priority back in Feb 2020, that's why it stayed in WIP.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthewphsmith matthewphsmith Awaiting requested review from matthewphsmith

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chanadian @kumare3