add server reflection (#19)

flyteorg · Nov 20, 2019 · b365a10 · b365a10
1 parent 65025b4
commit b365a10
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 8 deletions.
diff --git a/Gopkg.lock b/Gopkg.lock
diff --git a/cmd/entrypoints/serve.go b/cmd/entrypoints/serve.go
@@ -11,6 +11,7 @@ import (
 	"github.com/lyft/flytestdlib/logger"
 	"github.com/spf13/cobra"
 	"google.golang.org/grpc"
+	"google.golang.org/grpc/reflection"
 )
 
 var serveCmd = &cobra.Command{
@@ -53,6 +54,7 @@ func serveInsecure(ctx context.Context, cfg *config.Config) error {
 func newGRPCServer(_ context.Context) *grpc.Server {
 	grpcServer := grpc.NewServer()
 	datacatalog.RegisterDataCatalogServer(grpcServer, datacatalogservice.NewDataCatalogService())
+	reflection.Register(grpcServer)
 	return grpcServer
 }
 

diff --git a/cmd/entrypoints/serve_dummy.go b/cmd/entrypoints/serve_dummy.go
@@ -10,6 +10,7 @@ import (
 	"github.com/lyft/flytestdlib/logger"
 	"github.com/spf13/cobra"
 	"google.golang.org/grpc"
+	"google.golang.org/grpc/reflection"
 )
 
 var serveDummyCmd = &cobra.Command{
@@ -51,5 +52,6 @@ func serveDummy(ctx context.Context, cfg *config.Config) error {
 func newGRPCDummyServer(_ context.Context) *grpc.Server {
 	grpcServer := grpc.NewServer()
 	datacatalog.RegisterDataCatalogServer(grpcServer, &datacatalogservice.DataCatalogService{})
+	reflection.Register(grpcServer)
 	return grpcServer
 }