New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: slim image, use rustup, build deps only on armv7 #352

Merged

BenjiU merged 1 commit into flyte:develop from chatziko:docker-improve

Mar 1, 2024

Contributor

chatziko commented Feb 28, 2024 •

edited

Loading

A follow up to the reverted #342, with extra improvements:

Install rust from rustup. This seems to solve the issue reported in docker: use a "slim" base image #342
Remove the cryptography==3.3.2 hack, latest version builds fine with a recent rust.
Install rust and other build dependencies only on arm/v7 (needed cause cryptography has no binary wheel).
Use the TARGETPLATFORM predefined arg.

I tested that it builds on all platforms, but only ran it on arm64 (not on arm/v7).


          docker: slim image, use rustup, build deps only on armv7

14979f1

chatziko mentioned this pull request

docker: use a "slim" base image #342

Merged

BenjiU merged commit 0d1964d into flyte:develop

5 checks passed

Collaborator

BenjiU commented Mar 1, 2024

@chatziko: nice, it works!

Thanks a lot for the fix and your patient! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet