Pass additional KVM environment parameters into guest on cold boot and in ensure #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctheune
requested changes
Oct 16, 2024
sysvinit
force-pushed
the
PL-131857-signal-cold-reboot-changes
branch
from
b2574f7
to
ef278b0
Compare
In addition to the boot-time qemu binary generation, also separately seed the CPU flags and the RBD pool so the guest can detect changes at runtime.
sysvinit
force-pushed
the
PL-131857-signal-cold-reboot-changes
branch
from
ef278b0
to
b3c4598
Compare
sysvinit
changed the title
Allow the guest to detect whether the KVM environment has changed at runtime in combination with the boot-time seed data.
sysvinit
force-pushed
the
PL-131857-signal-cold-reboot-changes
branch
from
b3c4598
to
9e42515
Compare
ctheune
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mechanism similar to the qemu binary generation signalling (seeding in the tmp volume at cold boot and then periodically write into a file in the guest's /run at runtime) in order to signal additional parameters to the agent. Use this mechanism to signal the CPU flags and the RBD pool into the guest, so the guest can schedule a cold reboot to allow us to make the necessary changes after the qemu process has exited and before it's restarted.