-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21.05] devhost: Add VM operation mode (PL-131470) #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leona-ya
force-pushed
the
PL-131470-rebuild-devhost-with-vms
branch
4 times, most recently
from
May 11, 2023 15:25
5976cc4
to
eca975b
Compare
leona-ya
changed the title
Rebuild devhost with vms (PL-131470)
[21.05] Rebuild devhost with vms (PL-131470)
May 11, 2023
leona-ya
force-pushed
the
PL-131470-rebuild-devhost-with-vms
branch
17 times, most recently
from
May 17, 2023 19:50
82d3a24
to
c3bc365
Compare
leona-ya
force-pushed
the
PL-131470-rebuild-devhost-with-vms
branch
3 times, most recently
from
May 24, 2023 16:01
8654034
to
9e6cd90
Compare
leona-ya
force-pushed
the
PL-131470-rebuild-devhost-with-vms
branch
3 times, most recently
from
May 30, 2023 11:44
92c1fc6
to
df53fb6
Compare
I don't know how to fix the pre-commit test for private keys. I think I excluded it, but it's still failing. |
ctheune
force-pushed
the
PL-131470-rebuild-devhost-with-vms
branch
from
July 18, 2023 11:57
46c1bb6
to
320a692
Compare
The assertion broke evaluation when trying to evaluate a role which is deprecated with mkRemovedOptionModule
- Add new image `dev-vm` - Add new infrastructure mode `dev-vm` - Add feature switch in devhost role to switch between vms and container (while preserving default)
leona-ya
force-pushed
the
PL-131470-rebuild-devhost-with-vms
branch
from
July 18, 2023 18:34
320a692
to
ec49b05
Compare
leona-ya
force-pushed
the
PL-131470-rebuild-devhost-with-vms
branch
from
July 21, 2023 09:15
97a7e7e
to
8e7b473
Compare
leona-ya
force-pushed
the
PL-131470-rebuild-devhost-with-vms
branch
from
August 28, 2023 11:12
01cbb2e
to
a247ded
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@flyingcircusio/release-managers
Release process
Impact: None, since only activated if the new function is explicitly enabled.
Changelog:
Security implications