Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.05] devhost: Add VM operation mode (PL-131470) #704

Merged
merged 23 commits into from
Sep 14, 2023

Conversation

leona-ya
Copy link
Member

@leona-ya leona-ya commented May 4, 2023

@flyingcircusio/release-managers

Release process

Impact: None, since only activated if the new function is explicitly enabled.

Changelog:

  • devhost: Add new feature to use VMs instead of containers. The new feature is not enabled be default (PL-131470)

Security implications

  • Security requirements defined? (WHERE)
    • No change for existing customer, who use the devhost feature (i.e. default operation mode should be container)
      • Container mode should still work
    • Dev VM SSH should not be accessible from outside (they use an insecure ssh key)
  • Security requirements tested? (EVIDENCE)
    • New feature tested on largo and largo01
    • Dev VMs are by design not accessible from outside except https via the nginx proxy on the host - they use only internal IPv4 addresses

@leona-ya leona-ya force-pushed the PL-131470-rebuild-devhost-with-vms branch 4 times, most recently from 5976cc4 to eca975b Compare May 11, 2023 15:25
@leona-ya leona-ya changed the base branch from fc-22.11-dev to fc-21.05-dev May 11, 2023 15:25
@leona-ya leona-ya changed the title Rebuild devhost with vms (PL-131470) [21.05] Rebuild devhost with vms (PL-131470) May 11, 2023
@leona-ya leona-ya force-pushed the PL-131470-rebuild-devhost-with-vms branch 17 times, most recently from 82d3a24 to c3bc365 Compare May 17, 2023 19:50
@leona-ya leona-ya force-pushed the PL-131470-rebuild-devhost-with-vms branch 3 times, most recently from 8654034 to 9e6cd90 Compare May 24, 2023 16:01
@leona-ya leona-ya force-pushed the PL-131470-rebuild-devhost-with-vms branch 3 times, most recently from 92c1fc6 to df53fb6 Compare May 30, 2023 11:44
@leona-ya
Copy link
Member Author

I don't know how to fix the pre-commit test for private keys. I think I excluded it, but it's still failing.

@ctheune ctheune force-pushed the PL-131470-rebuild-devhost-with-vms branch from 46c1bb6 to 320a692 Compare July 18, 2023 11:57
@leona-ya leona-ya force-pushed the PL-131470-rebuild-devhost-with-vms branch from 320a692 to ec49b05 Compare July 18, 2023 18:34
@leona-ya leona-ya force-pushed the PL-131470-rebuild-devhost-with-vms branch from 97a7e7e to 8e7b473 Compare July 21, 2023 09:15
@leona-ya leona-ya force-pushed the PL-131470-rebuild-devhost-with-vms branch from 01cbb2e to a247ded Compare August 28, 2023 11:12
@dpausp dpausp merged commit e783143 into fc-21.05-dev Sep 14, 2023
1 check passed
@dpausp dpausp deleted the PL-131470-rebuild-devhost-with-vms branch September 14, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants