[24.11] fix postgres update tests #1180
Merged
+137
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This basically was a manual incrementation of all version numbers. As this is a rather cumbersome process, the next time such an update is needed we might want to restructure the version management code to something more abstract. Also adds coverage for postgres16.
- implement automatically adjusting permissions of new_data_dir - adjust to new data dir behaviour of empty new_data_dir already being created for a new postgresql version at system activation time - this fixes the test execution
osnyx
force-pushed
the
os-fix-postgres-update-tests
branch
from
2acf29b
to
daa6a52
Compare
The files in the postgres data dir do not need to be executable. Hence, the chmod needs to apply a different mode to files than directories.
This is supposedly more readable.
Fixing the permissions of just the top-level new_data_dir is sufficient to make the tests pass again. Reviewing this together with TS, we saw the danger of masking potential other issues or messing up permissions when fixing them recursively.
|
Reviewed this with @dpausp and made some adjustments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@flyingcircusio/release-managers
Follow-up to #1169. Fixes the postgresql-autoupgrade tests by adjusting the used postgresql versions and handling new behaviour regarding data directories.
development branch, the failing tests are fine and will be taken care of later.
Security implications