Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation (online&cached) added #4

Open
wants to merge 87 commits into
base: master
Choose a base branch
from
Open

Conversation

quaso
Copy link

@quaso quaso commented Jan 8, 2016

No description provided.

@flyandi
Copy link
Owner

flyandi commented Jan 8, 2016

Howdy - Thanks for the pull request. I just skimmed through your additions and it looks pretty good. I will test drive your code (literally).

Couple questions before I merge the request:

  1. Did you split out my menu maker?
  2. Maybe I missed it, but I didn't see anything related to input the address.
  3. You said over in the forums that the route recalculates itself every 5seconds - will that count against the API?
  4. I may want to reorganize some of your code, so we can better abstract from that. I was playing around with Google's routing API and had a similar implementation. Would be nice to get to a point to support different providers.

Anyway, I will test this weekend :-)

Good job!

@quaso
Copy link
Author

quaso commented Jan 8, 2016

Hi

  1. Yes, I moved menu into two separate js files. One contains menu data and the other contains list of menus. I was annoyed with one long menu, with your items and then items with navigation. So I created two menus and implemented a logic for having multiple independent menus.
  2. Input address is not implemented yet. One has to hardcode destination GPS coordinates into settings.js file. I do not like it, but it is quite fine for the beginning. I am planning to create some virtual keyboard (or use some existing one), so the user can enter the address. Graphhopper has even geocoding API, so I will use it.
  3. The route is recalculated only if you are off route. So when you are driving according to the route (+/- 30 metres), then there are no POST request. And yes, every route (re)calculation takes one credit at Graphhopper.
  4. I wasnt playing with other routing providers, because ffwdme project was using Graphhopper already. One of the great advatnages of this service is, that they provide you list of points. These points represents GPS coorditanes for the route. If you have one long road, then you receive just two points. But if you have curvy road, you receive tens of points. So I can use all these points in OpenLayers LineString to display the route. I do not know, if any other service provides this. However, I do not want to stick to one service provider only. That is why routing logic is based on info parsed from Graphhoper response (see parse method in graph_hopper.js). Actually it is only list of distances, turn types, and points at the route. I parse out instruction text and duration as well, but these are not used. So any service provider, which provides those three info can be used.

@flyandi
Copy link
Owner

flyandi commented Jan 8, 2016

The system already has a full keyboard instance that is used for the SMS and Email input. It's a simple object that is globally available. I will work on that part once I merged the pull request.

What's the ffwdme project?

@quaso
Copy link
Author

quaso commented Feb 3, 2016

At first I did not notice your test env, so I created my own. As it turned out lately, my changes in code are not compatible with your test env, but at least they are working in real car :). In near future I will put some effort into adjusting the code, so it will work in your test env and I can remove mine. Till that time, please use workaround and zip posted by brettalcox.

@quaso
Copy link
Author

quaso commented Feb 3, 2016

It was not so hard to fix actually :) There were some relative path issues. Please try now

@flyandi
Copy link
Owner

flyandi commented Feb 3, 2016

Ok - I will retry tonight. Thanks guys.

- webUI is able to edit locale and route color
@quaso quaso force-pushed the master branch 2 times, most recently from e35b4ad to 2578c34 Compare February 22, 2016 14:23
@kkaczmarczyk
Copy link

Was this tested in the end?;)

@quaso
Copy link
Author

quaso commented Sep 1, 2016

I tested it, but it was a long time ago :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants