Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct wording #821

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

correct wording #821

wants to merge 1 commit into from

Conversation

luk355
Copy link

@luk355 luk355 commented Mar 9, 2022

No description provided.

@dholbach dholbach added the blocked/requires-dco Pull requests that must be signed label Mar 12, 2022
@staceypotter
Copy link
Member

@luk355 do you have DCO? Can you sign off your commit please? Besides the DCO issue this change looks fine to me, but sign offs are required.

staceypotter
staceypotter reviewed Jul 12, 2022
View reviewed changes
Copy link
Member

@staceypotter staceypotter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this typo fix LGTM. :)

dholbach
dholbach previously approved these changes Jul 12, 2022
View reviewed changes
@dholbach dholbach self-requested a review July 12, 2022 20:36
@dholbach dholbach added the blocked/requires-rebase Pull requests that must be rebased label Oct 19, 2022
@dholbach dholbach removed their request for review November 30, 2022 09:35
@dholbach dholbach dismissed their stale review November 30, 2022 09:35

needs dco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staceypotter staceypotter staceypotter left review comments

@dholbach dholbach dholbach left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked/requires-dco Pull requests that must be signed blocked/requires-rebase Pull requests that must be rebased
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luk355 @staceypotter @dholbach