Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitOps Workflow Image #1462

Closed
wants to merge 1 commit into from
Closed

Conversation

FavourDaniel
Copy link
Contributor

Added GitOps Workflow image showing how it works with Flux to resolve issue #1420.

Added GitOps Workflow image showing how it works with Flux to resolve issue fluxcd#1420.

Signed-off-by: Daniel Favour <[email protected]>
@FavourDaniel
Copy link
Contributor Author

@stefanprodan Please can you review this? Also, I would like to know if I need to add additional information regarding the diagram and if I should make any edits.

@stefanprodan
Copy link
Member

Hey @FavourDaniel the following two weeks I'll be off, first week is KubeCon then I'm going on vacation. Let's discuss this when I get back please. I suggest we use https://excalidraw.com and we upload the source file in the repo, so anyone can modify it. Also the diagram is confusing to me, Flux doesn't pull images, it only lists tags, also that step with the manifest doesn't look good IMO, we need to incorporate it under the repo.

@FavourDaniel
Copy link
Contributor Author

Hey @FavourDaniel the following two weeks I'll be off, first week is KubeCon then I'm going on vacation. Let's discuss this when I get back please. I suggest we use https://excalidraw.com and we upload the source file in the repo, so anyone can modify it. Also the diagram is confusing to me, Flux doesn't pull images, it only lists tags, also that step with the manifest doesn't look good IMO, we need to incorporate it under the repo.

Alright, I will close this PR and make changes, thank you. Enjoy your vacation!

@stefanprodan
Copy link
Member

I'm working on diagrams today for my KubeCon talk, here is one made with excalidraw:

Screenshot 2023-04-14 at 15 54 51

Do you like this design?

@FavourDaniel
Copy link
Contributor Author

I'm working on diagrams today for my KubeCon talk, here is one made with excalidraw:

Screenshot 2023-04-14 at 15 54 51

Do you like this design?

Yes, this really good, love it. I'll try to replicate this design style with Excali as well, I'll reach out to you on Slack now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants