Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy support for GCS buckets #1565

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add proxy support for GCS buckets #1565

merged 1 commit into from
Aug 9, 2024

Conversation

matheuscscp
Copy link
Member

@matheuscscp matheuscscp commented Aug 2, 2024 •
edited
Loading

Part of #1563

I was able to manually test this using a JSON Service Account Key in my personal GCP account.

@matheuscscp matheuscscp force-pushed the bucket-gcp-proxy branch 3 times, most recently from 95023b5 to 42a405b Compare August 2, 2024 13:28
matheuscscp
matheuscscp commented Aug 2, 2024
View reviewed changes
api/v1beta2/bucket_types.go Show resolved Hide resolved
docs/spec/v1beta2/buckets.md Show resolved Hide resolved
@matheuscscp matheuscscp force-pushed the bucket-gcp-proxy branch 15 times, most recently from c4681d6 to 84c6636 Compare August 2, 2024 23:29
@matheuscscp matheuscscp marked this pull request as ready for review August 2, 2024 23:30
matheuscscp
matheuscscp commented Aug 3, 2024
View reviewed changes
pkg/gcp/gcp.go Outdated Show resolved Hide resolved
@matheuscscp matheuscscp mentioned this pull request Aug 5, 2024
Closed
5 tasks
@stefanprodan stefanprodan added the area/bucket Bucket related issues and pull requests label Aug 5, 2024
@matheuscscp matheuscscp force-pushed the bucket-gcp-proxy branch 3 times, most recently from 773d23c to 6fa0e56 Compare August 8, 2024 00:47
stefanprodan
stefanprodan approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🏅

darkowlzz
darkowlzz reviewed Aug 8, 2024
View reviewed changes
internal/controller/bucket_controller.go Outdated Show resolved Hide resolved
pkg/gcp/gcp.go Outdated Show resolved Hide resolved
pkg/gcp/gcp_test.go Outdated Show resolved Hide resolved
pkg/gcp/gcp.go Outdated Show resolved Hide resolved
@matheuscscp matheuscscp requested a review from darkowlzz August 9, 2024 12:00
darkowlzz
darkowlzz approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes look good to me.
Again, nice tests for verifying the functionality.

Left a minor comment about a test which can be addressed before merging.

@matheuscscp
Add proxy support for GCS buckets
31ed900 
Signed-off-by: Matheus Pimenta <[email protected]>
@matheuscscp matheuscscp merged commit 67f6cba into fluxcd:main Aug 9, 2024
9 checks passed
@matheuscscp matheuscscp deleted the bucket-gcp-proxy branch August 9, 2024 18:15
@stefanprodan stefanprodan added this to the Bucket GA milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
area/bucket Bucket related issues and pull requests
Projects
None yet
Milestone
Bucket GA
Development

Successfully merging this pull request may close these issues.
3 participants
@matheuscscp @darkowlzz @stefanprodan