Enable caching contextual Login Credentials #1521
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
force-pushed
the
enable-provider-auth-caching
branch
2 times, most recently
from
7070dd5 to
93cddf4
Compare
souleb
commented
Jun 20, 2024
| // NewOIDCAuthenticator returns a new OIDCAuthenticator. | ||
| // The capacity is the number of authenticators to cache. | ||
| // If the capacity is less than or equal to 0, the cache is disabled. | ||
| func NewOIDCAuthenticator(opts ...OIDCAuthenticatorOptionFunc) (*OIDCAuthenticator, error) { |
There was a problem hiding this comment.
We can later on add retry and evection logic to that struct
souleb
force-pushed
the
enable-provider-auth-caching
branch
from
93cddf4 to
e92327d
Compare
3 tasks
Provide an optional Cache to the Login Manager used to retrive contextual login credentials. Signed-off-by: Soule BA <[email protected]>
souleb
force-pushed
the
enable-provider-auth-caching
branch
from
e92327d to
5ecc6b1
Compare
|
generated metrics 
|
Comment on lines
+416
to
+419
| disabled, found := os.LookupEnv("LOGIN_CACHE_DISABLED") | ||
| if found && disabled == "true" { | ||
| capacity = -1 | ||
| } |
There was a problem hiding this comment.
Please implement this as a feature flag called CacheLoginTokens enabled by default.
stefanprodan
reviewed
Jul 3, 2024
| @@ -47,7 +47,7 @@ func NewCacheRecorder() *CacheRecorder { | |||
| return &CacheRecorder{ | |||
| cacheEventsCounter: prometheus.NewCounterVec( | |||
| prometheus.CounterOpts{ | |||
| Name: "gotk_cache_events_total", | |||
| Name: "gotk_sc_cache_events_total", | |||
There was a problem hiding this comment.
Changing the metric name is a breaking change, what is the reason for this change?
There was a problem hiding this comment.
there is a conflict in naming with the same metric in flux/pkg/cache. I'll remove the SC internal cache package to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an optional Cache to the Login Manager used to retrive contextual login credentials.