Use go-logr/logr interface for OCI auth logging
#805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
matheuscscp
approved these changes
Aug 23, 2024
darkowlzz
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
LGTM!
Ran the GCP integration test to exercise the auth change and it worked https://github.com/fluxcd/pkg/actions/runs/10532031187. CI failed due to a timeout from GCR, which has been observed before. All the other tests have passed. This failure on GCR seems almost as if the GCR requests require a cold boot to be served, as the subsequent GCR tests pass.
Left a minor comment about may be an unintended change which can be addressed before merge.
Signed-off-by: Stefan Prodan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the controller-runtime direct dependency from pkg/oci.