ssa: improve data masking #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
enhancement
hiddeco
force-pushed
the
ssa-data-masking
branch
2 times, most recently
from
75d43b7 to
116c542
Compare
Instead of masking the data with `****` or `*****`, provide an easier to distinguish `*** (before)` and `*** (after)` for values which have changed. Matching the output of `kubectl diff`. In addition, make the function public as it can be of use outside of the `Diff` of the resource manager, and allow passing only one instance of an object (for scenarios where a resource is either created or deleted). Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
ssa-data-masking
branch
from
116c542 to
19c86d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of masking the data with
****or*****, provide an easier to distinguish*** (before)and*** (after)for values which have changed. Matching the output ofkubectl diff.In addition, make the function public as it can be of use outside of the
Diffof the resource manager, and allow passing only one instance of an object (for scenarios where a resource is either created or deleted).