Merge pull request #164 from dieend/histogram-metrics

Change the metric bucket into a more useful range.
fluxcd · Mar 21, 2023 · 5da79e1 · 5da79e1
2 parents 9011841 + d19ab65
commit 5da79e1
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/runtime/metrics/recorder.go b/runtime/metrics/recorder.go
@@ -57,9 +57,10 @@ func NewRecorder() *Recorder {
 		),
 		durationHistogram: prometheus.NewHistogramVec(
 			prometheus.HistogramOpts{
-				Name:    "gotk_reconcile_duration_seconds",
-				Help:    "The duration in seconds of a GitOps Toolkit resource reconciliation.",
-				Buckets: prometheus.ExponentialBuckets(10e-9, 10, 10),
+				Name: "gotk_reconcile_duration_seconds",
+				Help: "The duration in seconds of a GitOps Toolkit resource reconciliation.",
+				// Use a histogram with 10 count buckets between 1ms - 1hour
+				Buckets: prometheus.ExponentialBucketsRange(10e-3, 1800, 10),
 			},
 			[]string{"kind", "name", "namespace"},
 		),