Fix: Make HelmChartTemplate a pointer in .spec.chart
#980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If implemented, this will omit empty `.spec.chart` in rendered yamls. Signed-off-by: Soule BA <[email protected]>
souleb
force-pushed
the
chartTemplate-as-pointer
branch
from
133532d to
16b61c6
Compare
stefanprodan
added
the
backport:release/v1.0.x
stefanprodan
changed the title
HelmChartTemplate a pointer in .spec.chart
|
Successfully created backport PR for |
|
@souleb @stefanprodan this is a breaking change to the v2beta2 types when using the api go module, just checking if that's something that needs to be documented in the changelog. |
|
@seaneagan if you need v2beta2 stay on api v0.x. In v1.0.0 we have deprecated v2beta2, no one should use it with this version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If implemented, this will omit empty
.spec.chartin rendered yamls.Required for: fluxcd/flux2#4766