Early stall condition detection after remediation #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
remediation-stall
branch
from
e4eede6 to
2456763
Compare
19 tasks
Detect stall condition due to exhausted remediation retry right after remediating. This helps return from AtomicRelease.Reconcile() with proper stalled status condition and error. Without this, after remediation, a stalled condition detection required a new reconciliation, leaving the status of the object without any Reconciling or Stalled condition. Signed-off-by: Sunny <[email protected]>
hiddeco
force-pushed
the
remediation-stall
branch
from
2456763 to
fa5e284
Compare
hiddeco
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Tested this by hand and it works as intended, thank you @darkowlzz 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect stall condition due to exhausted remediation retry right after remediating. This helps return from the AtomicRelease.Reconcile() with proper stalled status condition and error. Without this, after remediation, especially during upgrade failures, a stalled condition detection required a new reconciliation, leaving the status of the object without any Reconciling or Stalled condition.