Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase timeout delete-ns tests #836

Merged
merged 1 commit into from
Dec 8, 2023
Merged

ci: increase timeout delete-ns tests #836

merged 1 commit into from
Dec 8, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Dec 8, 2023

This test has shown to be a flake on multiple ocassions.

After running it locally a dozen of times, my conclusion is that the
time it takes for Kubernetes to shutdown a Pod may sometimes be a tiny
bit longer than anticipated by the current timeout.

Therefore, increase it to 5 minutes and provide more context on the
state of the namespace in case a timeout occurs.

@hiddeco hiddeco added the area/ci CI related issues and pull requests label Dec 8, 2023
@hiddeco hiddeco requested a review from darkowlzz December 8, 2023 17:16
This test has shown to be a flake on multiple ocassions.

After running it locally a dozen of times, my conclusion is that the
time it takes for Kubernetes to shutdown a Pod may sometimes be a tiny
bit longer than anticipated by the current timeout.

Therefore, increase it to 5 minutes and provide more context on the
state of the namespace in case a timeout occurs.

Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco hiddeco force-pushed the address-test-flake branch from f0211a8 to 8b19eb0 Compare December 8, 2023 17:17
@hiddeco hiddeco merged commit 7d7f081 into main Dec 8, 2023
6 checks passed
@hiddeco hiddeco deleted the address-test-flake branch December 8, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants