Remove stale remediated condition when in-sync #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
stale-remediated-in-sync
branch
3 times, most recently
from
7baedcb to
e627301
Compare
hiddeco
approved these changes
Dec 7, 2023
darkowlzz
force-pushed
the
stale-remediated-in-sync
branch
from
616ce88 to
d87018a
Compare
hiddeco
reviewed
Dec 8, 2023
darkowlzz
force-pushed
the
stale-remediated-in-sync
branch
2 times, most recently
from
871de13 to
5a20c32
Compare
hiddeco
approved these changes
Dec 8, 2023
Remediation can roll back to a version that matches with the next good config. In such situation, release will be in-sync and no action will be performed. The status conditions will continue to show Remediated=True and Released=False. Check and remove stale Remediated condition and add a Released=True condition with message constructed from the latest release. Introduce replaceCondition() to replaces target condition with a replacement condition, retaining the transition time. This helps ensure that the last transition time of releases don't change when a release is marked from remediated to released. Signed-off-by: Sunny <[email protected]>
darkowlzz
force-pushed
the
stale-remediated-in-sync
branch
from
5a20c32 to
9eb596e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remediation can roll back to a version that matches with the next good config. In such situation, release will be in-sync and no action will be performed. The status conditions will continue to show Remediated=True and Released=False. Check and remove stale Remediated condition and add a Released=True condition with message constructed from the latest release.
Before this change, a release could end up in the following state:
After this change: