Various minor fixes #825
Merged
Various minor fixes #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
various-minor-fixes
branch
2 times, most recently
from
cf1b678 to
1427495
Compare
This ensures that on repetitive failures, the number of snapshots does not grow indefinitely due to there not being any in a superseded or deployed state. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
various-minor-fixes
branch
from
1427495 to
688b636
Compare
This ensures that any unfulfilled dependencies for which we requeue do not prematurely bump the observed generation by introducing typed errors. These typed errors ensure that the logic to bump the observed generation can continue to be the same, while ignoring them just in time before returning the final error. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
various-minor-fixes
branch
3 times, most recently
from
2277499 to
8afea70
Compare
Signed-off-by: Hidde Beydals <[email protected]>
This ensures that if there is no target to roll back to due to all of them being in a failed state, the controller stalls instead of ending up in a loop of upgrade attempts. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
various-minor-fixes
branch
from
8afea70 to
51563d6
Compare
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
This avoids having a confusing "stale" Remediated condition when a new release has been attempted. Signed-off-by: Hidde Beydals <[email protected]>
darkowlzz
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.