Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete code and tidy things #819

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Remove obsolete code and tidy things #819

merged 5 commits into from
Nov 24, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Nov 24, 2023

Depends on #815

@hiddeco hiddeco added the hold Issues and pull requests put on hold label Nov 24, 2023
This used to drive the logic behind the `v2beta1` API, but has now
become obsolete with the `action` sub-module as its successor.

Signed-off-by: Hidde Beydals <[email protected]>
This code is now available in upstream controller-runtime.

Signed-off-by: Hidde Beydals <[email protected]>
These functions are no longer in use by the actual code base, while the
same outcome can be achieved by using `LastRelease` in combination with
`VerifyReleaseObject`.

Signed-off-by: Hidde Beydals <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiddeco hiddeco merged commit f7185d4 into main Nov 24, 2023
6 checks passed
@hiddeco hiddeco deleted the tidy-code branch November 24, 2023 17:19
@hiddeco hiddeco removed the hold Issues and pull requests put on hold label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants