Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of snapshot digest algorithm #818

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Nov 24, 2023

This introduces a --snapshot-digest-algo flag to allow configuring a different algorithm than SHA256.

This allows the user to for example configure blake3, which is potentially faster (and less resource intensive) on modern hardware.

@hiddeco hiddeco added the enhancement New feature or request label Nov 24, 2023
@hiddeco hiddeco changed the title Allow configuration of digest algorithm Allow configuration of snapshot digest algorithm Nov 24, 2023
@hiddeco hiddeco force-pushed the allow-digest-config branch from c3cfd33 to f69fff4 Compare November 24, 2023 17:02
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This introduces a `--snapshot-digest-algo` flag to allow configuring a
different algorithm than SHA256.

This allows the user to for example configure `blake3`, which is
potentially faster (and less resource intensive) on modern hardware.

Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco hiddeco force-pushed the allow-digest-config branch from f69fff4 to 7a70bd5 Compare November 24, 2023 17:20
@hiddeco hiddeco merged commit 6ec21ab into main Nov 24, 2023
6 checks passed
@hiddeco hiddeco deleted the allow-digest-config branch November 24, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants