Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'Deprecated' comments to own paragraph #1000

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Move 'Deprecated' comments to own paragraph #1000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7304df6
Move 'Deprecated' comments to own paragraph
hoffimar May 31, 2024
f98033e
Generate docu
hoffimar May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/v2/helmrelease_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,11 +999,13 @@ type HelmReleaseStatus struct {

// LastAttemptedValuesChecksum is the SHA1 checksum for the values of the last
// reconciliation attempt.
//
// Deprecated: Use LastAttemptedConfigDigest instead.
// +optional
LastAttemptedValuesChecksum string `json:"lastAttemptedValuesChecksum,omitempty"`

// LastReleaseRevision is the revision of the last successful Helm release.
//
// Deprecated: Use History instead.
// +optional
LastReleaseRevision int `json:"lastReleaseRevision,omitempty"`
Expand Down
1 change: 1 addition & 0 deletions api/v2beta1/helmrelease_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,6 +1205,7 @@ func (in *HelmRelease) SetConditions(conditions []metav1.Condition) {
}

// GetStatusConditions returns a pointer to the Status.Conditions slice.
//
// Deprecated: use GetConditions instead.
func (in *HelmRelease) GetStatusConditions() *[]metav1.Condition {
return &in.Status.Conditions
Expand Down
6 changes: 6 additions & 0 deletions api/v2beta2/helmrelease_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,13 @@ type Kustomize struct {
Patches []kustomize.Patch `json:"patches,omitempty"`

// Strategic merge patches, defined as inline YAML objects.
//
// Deprecated: use Patches instead.
// +optional
PatchesStrategicMerge []apiextensionsv1.JSON `json:"patchesStrategicMerge,omitempty"`

// JSON 6902 patches, defined as inline YAML objects.
//
// Deprecated: use Patches instead.
// +optional
PatchesJSON6902 []kustomize.JSON6902Patch `json:"patchesJson6902,omitempty"`
Expand Down Expand Up @@ -1011,6 +1013,7 @@ type HelmReleaseStatus struct {

// LastAppliedRevision is the revision of the last successfully applied
// source.
//
// Deprecated: the revision can now be found in the History.
// +optional
LastAppliedRevision string `json:"lastAppliedRevision,omitempty"`
Expand All @@ -1028,11 +1031,13 @@ type HelmReleaseStatus struct {

// LastAttemptedValuesChecksum is the SHA1 checksum for the values of the last
// reconciliation attempt.
//
// Deprecated: Use LastAttemptedConfigDigest instead.
// +optional
LastAttemptedValuesChecksum string `json:"lastAttemptedValuesChecksum,omitempty"`

// LastReleaseRevision is the revision of the last successful Helm release.
//
// Deprecated: Use History instead.
// +optional
LastReleaseRevision int `json:"lastReleaseRevision,omitempty"`
Expand Down Expand Up @@ -1266,6 +1271,7 @@ func (in *HelmRelease) SetConditions(conditions []metav1.Condition) {
}

// GetStatusConditions returns a pointer to the Status.Conditions slice.
//
// Deprecated: use GetConditions instead.
func (in *HelmRelease) GetStatusConditions() *[]metav1.Condition {
return &in.Status.Conditions
Expand Down
14 changes: 14 additions & 0 deletions config/crd/bases/helm.toolkit.fluxcd.io_helmreleases.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,6 +1133,8 @@ spec:
description: |-
LastAttemptedValuesChecksum is the SHA1 checksum for the values of the last
reconciliation attempt.


Deprecated: Use LastAttemptedConfigDigest instead.
type: string
lastHandledForceAt:
Expand All @@ -1154,6 +1156,8 @@ spec:
lastReleaseRevision:
description: |-
LastReleaseRevision is the revision of the last successful Helm release.


Deprecated: Use History instead.
type: integer
observedGeneration:
Expand Down Expand Up @@ -3039,6 +3043,8 @@ spec:
patchesJson6902:
description: |-
JSON 6902 patches, defined as inline YAML objects.


Deprecated: use Patches instead.
items:
description: JSON6902Patch contains a JSON6902 patch and
Expand Down Expand Up @@ -3135,6 +3141,8 @@ spec:
patchesStrategicMerge:
description: |-
Strategic merge patches, defined as inline YAML objects.


Deprecated: use Patches instead.
items:
x-kubernetes-preserve-unknown-fields: true
Expand Down Expand Up @@ -3661,6 +3669,8 @@ spec:
description: |-
LastAppliedRevision is the revision of the last successfully applied
source.


Deprecated: the revision can now be found in the History.
type: string
lastAttemptedConfigDigest:
Expand Down Expand Up @@ -3697,6 +3707,8 @@ spec:
description: |-
LastAttemptedValuesChecksum is the SHA1 checksum for the values of the last
reconciliation attempt.


Deprecated: Use LastAttemptedConfigDigest instead.
type: string
lastHandledForceAt:
Expand All @@ -3718,6 +3730,8 @@ spec:
lastReleaseRevision:
description: |-
LastReleaseRevision is the revision of the last successful Helm release.


Deprecated: Use History instead.
type: integer
observedGeneration:
Expand Down
8 changes: 4 additions & 4 deletions docs/api/v2/helm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1604,8 +1604,8 @@ string
<td>
<em>(Optional)</em>
<p>LastAttemptedValuesChecksum is the SHA1 checksum for the values of the last
reconciliation attempt.
Deprecated: Use LastAttemptedConfigDigest instead.</p>
reconciliation attempt.</p>
<p>Deprecated: Use LastAttemptedConfigDigest instead.</p>
</td>
</tr>
<tr>
Expand All @@ -1617,8 +1617,8 @@ int
</td>
<td>
<em>(Optional)</em>
<p>LastReleaseRevision is the revision of the last successful Helm release.
Deprecated: Use History instead.</p>
<p>LastReleaseRevision is the revision of the last successful Helm release.</p>
<p>Deprecated: Use History instead.</p>
</td>
</tr>
<tr>
Expand Down