Skip to content

Commit

Permalink
Loosen dependency check
Browse files Browse the repository at this point in the history
Dependency checks do not account for upgrade ordering,
so we only care about having the Ready condition set to
True, no matter the observed generation.

Signed-off-by: Stefan Prodan <[email protected]>
  • Loading branch information
stefanprodan committed Jan 18, 2024
1 parent 5c340a1 commit dfe4058
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/controller/helmrelease_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ func (r *HelmReleaseReconciler) checkDependencies(ctx context.Context, obj *v2.H
return fmt.Errorf("unable to get '%s' dependency: %w", ref, err)
}

if dHr.Generation != dHr.Status.ObservedGeneration || !conditions.IsTrue(dHr, meta.ReadyCondition) {
if !conditions.IsTrue(dHr, meta.ReadyCondition) {
return fmt.Errorf("dependency '%s' is not ready", ref)
}
}
Expand Down

0 comments on commit dfe4058

Please sign in to comment.