action: omit logging on CRD apply no-op

As it does not offer real value, and creates noise when the logs are included in an emitted event. Signed-off-by: Hidde Beydals <[email protected]>
fluxcd · Nov 22, 2023 · c520a3e · c520a3e
1 parent f56a10c
commit c520a3e
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/internal/action/crds.go b/internal/action/crds.go
@@ -65,13 +65,12 @@ func (*rootScoped) Name() apimeta.RESTScopeName {
 }
 
 func applyCRDs(cfg *helmaction.Configuration, policy v2.CRDsPolicy, chrt *helmchart.Chart, visitorFunc ...resource.VisitorFunc) error {
-	if policy == v2.Skip {
-		cfg.Log("skipping CustomResourceDefinition apply: policy is set to %s", policy)
+	if len(chrt.CRDObjects()) == 0 {
 		return nil
 	}
 
-	if len(chrt.CRDObjects()) == 0 {
-		cfg.Log("skipping CustomResourceDefinition apply: no CRD objects found in chart")
+	if policy == v2.Skip {
+		cfg.Log("skipping CustomResourceDefinition apply: policy is set to %s", policy)
 		return nil
 	}