replace _ with + for OCI artifacts tags when pulled for helm

Signed-off-by: Bogdan-Adrian Burciu <[email protected]>

internal/controller/helmrelease_controller.go

@@ -916,7 +916,10 @@ func mutateChartWithSourceRevision(chart *chart.Chart, source sourcev1.Source) (
 	switch {
 	case strings.Contains(revision, "@"):
 		tagD := strings.Split(revision, "@")
-		tagVer, err := semver.NewVersion(tagD[0])
+		// replace '+' with '_' for OCI tag semver compatibility
+		// per https://github.com/helm/helm/blob/v3.14.4/pkg/registry/client.go#L45-L50
+		tagConverted := strings.ReplaceAll(tagD[0], "_", "+")
+		tagVer, err := semver.NewVersion(tagConverted)
 		if err != nil {
 			return "", fmt.Errorf("failed parsing artifact revision %s", tagD[0])
 		}