Remove deprecated .status.lastAppliedRevision from v1 API

Signed-off-by: Stefan Prodan <[email protected]>

api/v2/helmrelease_types.go

@@ -991,12 +991,6 @@ type HelmReleaseStatus struct {
 	// +optional
 	UpgradeFailures int64 `json:"upgradeFailures,omitempty"`
 
-	// LastAppliedRevision is the revision of the last successfully applied
-	// source.
-	// Deprecated: the revision can now be found in the History.
-	// +optional
-	LastAppliedRevision string `json:"lastAppliedRevision,omitempty"`
-
 	// LastAttemptedRevision is the Source revision of the last reconciliation
 	// attempt. For OCIRepository  sources, the 12 first characters of the digest are
 	// appended to the chart version e.g. "1.2.3+1234567890ab".
@@ -1247,18 +1241,12 @@ func (in *HelmRelease) SetConditions(conditions []metav1.Condition) {
 	in.Status.Conditions = conditions
 }
 
-// GetStatusConditions returns a pointer to the Status.Conditions slice.
-// Deprecated: use GetConditions instead.
-func (in *HelmRelease) GetStatusConditions() *[]metav1.Condition {
-	return &in.Status.Conditions
-}
-
-// IsChartRefPresent returns true if the HelmRelease has a ChartRef.
+// HasChartRef returns true if the HelmRelease has a ChartRef.
 func (in *HelmRelease) HasChartRef() bool {
 	return in.Spec.ChartRef != nil
 }
 
-// IsChartTemplatePresent returns true if the HelmRelease has a ChartTemplate.
+// HasChartTemplate returns true if the HelmRelease has a ChartTemplate.
 func (in *HelmRelease) HasChartTemplate() bool {
 	return in.Spec.Chart.Spec.Chart != ""
 }

config/crd/bases/helm.toolkit.fluxcd.io_helmreleases.yaml

@@ -1198,12 +1198,6 @@ spec:
                   state. It is reset after a successful reconciliation.
                 format: int64
                 type: integer
-              lastAppliedRevision:
-                description: |-
-                  LastAppliedRevision is the revision of the last successfully applied
-                  source.
-                  Deprecated: the revision can now be found in the History.
-                type: string
               lastAttemptedConfigDigest:
                 description: |-
                   LastAttemptedConfigDigest is the digest for the config (better known as

docs/api/v2/helm.md

@@ -1556,20 +1556,6 @@ state. It is reset after a successful reconciliation.</p>
 </tr>
 <tr>
 <td>
-<code>lastAppliedRevision</code><br>
-<em>
-string
-</em>
-</td>
-<td>
-<em>(Optional)</em>
-<p>LastAppliedRevision is the revision of the last successfully applied
-source.
-Deprecated: the revision can now be found in the History.</p>
-</td>
-</tr>
-<tr>
-<td>
 <code>lastAttemptedRevision</code><br>
 <em>
 string

internal/reconcile/atomic_release.go

@@ -315,10 +315,6 @@ func (r *AtomicRelease) actionForState(ctx context.Context, req *Request, state
 		}
 		req.Object.Status.History.Truncate(ignoreFailures)
 
-		// TODO(hidde): this allows existing UIs to continue to display this
-		//  field, but should be removed in a future release.
-		req.Object.Status.LastAppliedRevision = req.Object.Status.History.Latest().ChartVersion
-
 		if forceRequested {
 			log.Info(msgWithReason("forcing upgrade for in-sync release", "force requested through annotation"))
 			return NewUpgrade(r.configFactory, r.eventRecorder), nil