Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies #254

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Updating dependencies #254

merged 1 commit into from
Dec 12, 2023

Conversation

souleb
Copy link
Member

@souleb souleb commented Dec 11, 2023

Description

Updating the following dependencies:

  • github.com/google/go-github
  • code.gitea.io/sdk/gitea
  • github.com/xanzy/go-gitlab
  • github.com/go-logr/logr
  • gitea e2e test version to v1.21.1

Test results


require (
code.gitea.io/sdk/gitea v0.16.0
code.gitea.io/sdk/gitea v0.17.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it we should probably upgrade the gitea version used for the e2e tests.

@souleb souleb force-pushed the update-go-121-deps branch from 2d72189 to c03bf60 Compare December 11, 2023 17:11
go.mod Outdated Show resolved Hide resolved
@souleb souleb force-pushed the update-go-121-deps branch 3 times, most recently from 2e93afe to 846fd5c Compare December 12, 2023 08:10
@souleb souleb changed the title Updating go to go1.21 Updating dependencies Dec 12, 2023
@souleb souleb requested a review from stefanprodan December 12, 2023 08:23
@stefanprodan stefanprodan added the dependencies Pull requests that update a dependency file label Dec 12, 2023
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb please squash the two commits and rename it to "Updating dependencies"

updating the following deps:
- github.com/google/go-github
- code.gitea.io/sdk/gitea
- github.com/xanzy/go-gitlab
- github.com/go-logr/logr
- gitea e2e test version to v1.21.1

Signed-off-by: Soule BA <[email protected]>
@souleb souleb force-pushed the update-go-121-deps branch from 846fd5c to 334d0a0 Compare December 12, 2023 09:01
@souleb souleb merged commit 1f17f86 into main Dec 12, 2023
9 checks passed
@souleb souleb deleted the update-go-121-deps branch December 12, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants