Fix GitHub bootstrap for repositories with custom properties #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
fix-github-bootstrap
branch
from
82b47fc to
1ac06fd
Compare
darkowlzz
reviewed
Aug 29, 2024
Comment on lines
-76
to
-83
| if ok, err := client.HasTokenPermission(context.Background(), gitprovider.TokenPermissionRWRepository); err != nil { | ||
| log.Fatalf("error getting token permission: %s", err) | ||
| } else { | ||
| if !ok { | ||
| log.Fatal("token has no write permissions") | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I couldn't figure out the reasoning behind removing this. The Client.HasTokenPermission() API still exists in [email protected]. Is it a debug change?
Some hint in the commit body would be helpful.
There was a problem hiding this comment.
It's broken due an API change upstream and it's really useless here.
darkowlzz
approved these changes
Aug 29, 2024
|
We have the confirmation that this fix works: #4957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #4958
Xref: google/go-github#3230