feat: expose HelmRelease IgnoreMissingValuesFiles feature #4755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Breathe <[email protected]>
stefanprodan
requested changes
May 3, 2024
Comment on lines
+244
to
+246
| if helmReleaseArgs.ignoreMissingValueFiles && os.IsNotExist(err) { | ||
| continue | ||
| } |
There was a problem hiding this comment.
This is not what the flag should, we should map it to HelmRelease spec instead of skipping over value files passed to the CLI.
There was a problem hiding this comment.
I think PR is probably unnecessary then. It only made sense to me if you were passing --values-files and --ignore-missing-values-files together (which we're not ourselves planning to do). Let's drop it.
|
Redundant change :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Breathe [email protected]