Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions required for flow control #4687

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

carlpett
Copy link
Contributor

As mentioned in the linked issue, all components use HEAD requests to /livez/ping to determine rate limits. This PR adds the required permissions to call the endpoint.

Fixes fluxcd/source-controller#1411

@stefanprodan stefanprodan added the area/security Security related issues and pull requests label Mar 25, 2024
@carlpett
Copy link
Contributor Author

E2E failure appears to be unrelated, complains about wrong Go version in go.mod?

@stefanprodan
Copy link
Member

Yeah controller-runtime is broken in upstream

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @carlpett 🏅

@stefanprodan stefanprodan merged commit 60bb4ff into fluxcd:main Mar 25, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Security related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document need for permission to /livez/ping
2 participants