Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show distribution name in flux check and flux version #4424

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Show distribution name in flux check and flux version #4424

merged 1 commit into from
Dec 6, 2023

Conversation

somtochiama
Copy link
Member

Fixes: #4343

stefanprodan
stefanprodan approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama

@stefanprodan stefanprodan marked this pull request as ready for review December 5, 2023 08:40
@stefanprodan stefanprodan added the area/ux In pursuit of a delightful user experience label Dec 5, 2023
stefanprodan
stefanprodan reviewed Dec 5, 2023
View reviewed changes
cmd/flux/version.go Outdated Show resolved Hide resolved
@stefanprodan stefanprodan mentioned this pull request Dec 5, 2023
Closed
14 tasks
@darkowlzz darkowlzz changed the title Show cluster instance name and version in flux check and flux version Show distribution name in flux check and flux version Dec 5, 2023
darkowlzz
darkowlzz reviewed Dec 5, 2023
View reviewed changes
cmd/flux/check.go Outdated Show resolved Hide resolved
cmd/flux/check.go Outdated Show resolved Hide resolved
cmd/flux/check.go Show resolved Hide resolved
cmd/flux/check.go Outdated Show resolved Hide resolved
cmd/flux/check.go Outdated Show resolved Hide resolved
cmd/flux/cluster_info.go Outdated Show resolved Hide resolved
cmd/flux/cluster_info.go Show resolved Hide resolved
cmd/flux/cluster_info.go Outdated Show resolved Hide resolved
cmd/flux/version.go Outdated Show resolved Hide resolved
cmd/flux/version.go Outdated Show resolved Hide resolved
@somtochiama somtochiama requested a review from darkowlzz December 6, 2023 10:20
darkowlzz
darkowlzz approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please squash the commits before merge.

@darkowlzz darkowlzz merged commit 3da7e1c into fluxcd:main Dec 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
area/ux In pursuit of a delightful user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show distribution name in flux version and flux check
3 participants
@somtochiama @darkowlzz @stefanprodan