Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI flags for OCIRepository signature verification #4332

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Add CLI flags for OCIRepository signature verification #4332

merged 1 commit into from
Oct 17, 2023

Conversation

matheuscscp
Copy link
Member

No description provided.

stefanprodan
stefanprodan reviewed Oct 15, 2023
View reviewed changes
cmd/flux/create_source_oci.go Outdated Show resolved Hide resolved
cmd/flux/create_source_oci.go Outdated Show resolved Hide resolved
@matheuscscp matheuscscp force-pushed the oci-verify-secret branch 3 times, most recently from 90d37cb to 0da547b Compare October 15, 2023 17:59
stefanprodan
stefanprodan reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok now. Can you please add tests, for when we error out due to provider not set and for export when secret ref is specified.

stefanprodan
stefanprodan approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🏅

@stefanprodan stefanprodan added area/oci OCI related issues and pull requests area/ux In pursuit of a delightful user experience labels Oct 17, 2023
@stefanprodan stefanprodan changed the title Add CLI flag for OCIRepo verify secret Add CLI flags for OCIRepository signature verification Oct 17, 2023
@stefanprodan stefanprodan merged commit ac95ac0 into fluxcd:main Oct 17, 2023
9 checks passed
@matheuscscp matheuscscp deleted the oci-verify-secret branch October 17, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/oci OCI related issues and pull requests area/ux In pursuit of a delightful user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheuscscp @stefanprodan