-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap: Fix error msg when the Git token doesn't match the repo owner #4324
Conversation
--personal
flag
This is much better than before. One thing we could still improve on would be that the message |
--personal
flagThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the two commits.
More like the wrong string is passed into the |
f51917f
to
7935239
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @somtochiama 🏅
Maybe |
@somtochiama please make the changes upstream, we'll do another patch release of ggp then you can update this PR. |
Signed-off-by: Somtochi Onyekwere <[email protected]>
7935239
to
08cb385
Compare
Successfully created backport PR for |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [fluxcd/flux2](https://github.com/fluxcd/flux2) | Kustomization | patch | `v2.1.1` -> `v2.1.2` | --- > ⚠ **Warning** > > Some dependencies could not be looked up. Check the warning logs for more information. --- ### Release Notes <details> <summary>fluxcd/flux2 (fluxcd/flux2)</summary> ### [`v2.1.2`](https://github.com/fluxcd/flux2/releases/tag/v2.1.2) [Compare Source](fluxcd/flux2@v2.1.1...v2.1.2) #### Highlights Flux `v2.1.2` is a patch release which comes with various fixes. Users are encouraged to upgrade for the best experience. ##### Fixes - Ensures faster recovery of `Kustomization` and `HelmRelease` resources when the source-controller has restarted and is working on restoring the storage. - Prevent source-controller from failing to reconcile `OCIRepositories` when artifacts contain symlinks. - Addresses issue with helm-controller miss-labeling Custom Resource Definitions. - Detect immutable field errors in Google Cloud resources managed by Flux `Kustomizations`. - Better error reporting for `flux bootstrap` when the owner doesn't match the identity associated with the given token. - Allow `flux pull artifact` to fetch OCI artifacts produced by other tools. #### Components changelog - source-controller [v1.1.2](https://github.com/fluxcd/source-controller/blob/v1.1.2/CHANGELOG.md) - kustomize-controller [v1.1.1](https://github.com/fluxcd/kustomize-controller/blob/v1.1.1/CHANGELOG.md) - helm-controller [v0.36.2](https://github.com/fluxcd/helm-controller/blob/v0.36.2/CHANGELOG.md) #### CLI Changelog - PR [#​4324](fluxcd/flux2#4324) - [@​somtochiama](https://github.com/somtochiama) - bootstrap: Fix error msg when the Git token doesn't match the repo owner - PR [#​4323](fluxcd/flux2#4323) - [@​stefanprodan](https://github.com/stefanprodan) - e2e: Update Go dependencies - PR [#​4313](fluxcd/flux2#4313) - [@​fluxcdbot](https://github.com/fluxcdbot) - Update toolkit components - PR [#​4296](fluxcd/flux2#4296) - [@​Skarlso](https://github.com/Skarlso) - fix: only wait for changeset if the result is not empty - PR [#​4285](fluxcd/flux2#4285) - [@​matheuscscp](https://github.com/matheuscscp) - Add badge for SLSA Level 3 - PR [#​4284](fluxcd/flux2#4284) - [@​errordeveloper](https://github.com/errordeveloper) - Make `flux pull` work for OCI artifacts produced by other tools </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMy4wIiwidXBkYXRlZEluVmVyIjoiMzcuMTMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/143 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>
When running flux bootstrap with the wrong user (and the repository already exists) returns this confusing error because
ggp tries to create the repository under the authenticated user.
With these changes, we give a better error
Closes: #3867