Make flux debug hr single flag selection required

Signed-off-by: Stefan Prodan <[email protected]>
fluxcd · Dec 23, 2024 · 5208515 · 5208515
1 parent 928ea24
commit 5208515
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/cmd/flux/debug_helmrelease.go b/cmd/flux/debug_helmrelease.go
@@ -63,7 +63,8 @@ func init() {
 func debugHelmReleaseCmdRun(cmd *cobra.Command, args []string) error {
 	name := args[0]
 
-	if debugHelmReleaseArgs.showStatus == false && debugHelmReleaseArgs.showValues == false {
+	if (!debugHelmReleaseArgs.showStatus && !debugHelmReleaseArgs.showValues) ||
+		(debugHelmReleaseArgs.showStatus && debugHelmReleaseArgs.showValues) {
 		return fmt.Errorf("either --show-status or --show-values must be set")
 	}
 
@@ -88,9 +89,7 @@ func debugHelmReleaseCmdRun(cmd *cobra.Command, args []string) error {
 		}
 		rootCmd.Println("# Status documentation: https://fluxcd.io/flux/components/helm/helmreleases/#helmrelease-status")
 		rootCmd.Print(string(status))
-		if debugHelmReleaseArgs.showValues {
-			rootCmd.Println("---")
-		}
+		return nil
 	}
 
 	if debugHelmReleaseArgs.showValues {