Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typo in AutoscalerReference type name #1739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct typo in AutoscalerReference type name #1739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/apis/flagger/v1beta1/canary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ type CanarySpec struct {

// AutoscalerRef references an autoscaling resource
// +optional
AutoscalerRef *AutoscalerRefernce `json:"autoscalerRef,omitempty"`
AutoscalerRef *AutoscalerReference `json:"autoscalerRef,omitempty"`

// Reference to NGINX ingress resource
// +optional
Expand Down Expand Up @@ -458,7 +458,7 @@ type LocalObjectReference struct {
Name string `json:"name"`
}

type AutoscalerRefernce struct {
type AutoscalerReference struct {
// API version of the scaler
// +required
APIVersion string `json:"apiVersion,omitempty"`
Expand Down
10 changes: 5 additions & 5 deletions pkg/apis/flagger/v1beta1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/canary/deployment_fixture_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ func newDeploymentControllerTestCanary(cc canaryConfigs) *flaggerv1.Canary {
APIVersion: "apps/v1",
Kind: "Deployment",
},
AutoscalerRef: &flaggerv1.AutoscalerRefernce{
AutoscalerRef: &flaggerv1.AutoscalerReference{
Name: "podinfo",
APIVersion: "autoscaling/v2beta2",
Kind: "HorizontalPodAutoscaler",
Expand Down
2 changes: 1 addition & 1 deletion pkg/canary/scaled_object_reconciler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func Test_setPrimaryScaledObjectQueries(t *testing.T) {
TargetRef: flaggerv1.LocalObjectReference{
Name: "podinfo",
},
AutoscalerRef: &flaggerv1.AutoscalerRefernce{
AutoscalerRef: &flaggerv1.AutoscalerReference{
Name: "podinfo",
},
},
Expand Down
4 changes: 2 additions & 2 deletions pkg/controller/scheduler_deployment_fixture_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ func newDeploymentTestCanary() *flaggerv1.Canary {
APIVersion: "apps/v1",
Kind: "Deployment",
},
AutoscalerRef: &flaggerv1.AutoscalerRefernce{
AutoscalerRef: &flaggerv1.AutoscalerReference{
Name: "podinfo",
APIVersion: "autoscaling/v2beta2",
Kind: "HorizontalPodAutoscaler",
Expand Down Expand Up @@ -358,7 +358,7 @@ func newDeploymentTestCanaryAB() *flaggerv1.Canary {
APIVersion: "apps/v1",
Kind: "Deployment",
},
AutoscalerRef: &flaggerv1.AutoscalerRefernce{
AutoscalerRef: &flaggerv1.AutoscalerReference{
Name: "podinfo",
APIVersion: "autoscaling/v2beta2",
Kind: "HorizontalPodAutoscaler",
Expand Down
Loading