Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add support for KEDA HTTPScaledObjects via HTTPScaledObjectReconciler #1714

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kahirokunn
Copy link
Contributor

@kahirokunn kahirokunn commented Oct 25, 2024

This PR adds support for KEDA HTTPScaledObjects to be used as an auto scaler for workloads. A new HTTPScaledObjectReconciler named HTTPScaledObjectReconciler has been introduced which reconciles HTTPScaledObjects. Users can specify a reference to their existing HTTPScaledObject using .spec.autoscalerRef in the Canary definition.
It has been tested on my cluster.

@kahirokunn kahirokunn changed the title add support for KEDA HTTPScaledObjects via HTTPScaledObjectReconciler [WIP] add support for KEDA HTTPScaledObjects via HTTPScaledObjectReconciler Oct 25, 2024
@kahirokunn kahirokunn force-pushed the support-http-scaled-object branch 13 times, most recently from 3b40a1d to cf8c8ca Compare November 1, 2024 09:03
@kahirokunn kahirokunn force-pushed the support-http-scaled-object branch 3 times, most recently from a3e0f56 to ae00dd2 Compare November 7, 2024 09:00
@kahirokunn
Copy link
Contributor Author

Hello @stefanprodan,

I'm interested in creating a diagram for Flagger, and I'd like to know which tools and materials you use to design Flagger diagrams. Could you kindly share any resources or tips on the preferred tools, styles, or specific assets used? I want to ensure consistency with existing diagrams.

Thank you very much for your help!

@kahirokunn kahirokunn force-pushed the support-http-scaled-object branch 10 times, most recently from 18f4c33 to 4d35e6d Compare November 8, 2024 07:32
@kahirokunn kahirokunn changed the title [WIP] add support for KEDA HTTPScaledObjects via HTTPScaledObjectReconciler add support for KEDA HTTPScaledObjects via HTTPScaledObjectReconciler Nov 12, 2024
@kahirokunn
Copy link
Contributor Author

@aryan9600
I hope you're doing well!
Could you kindly review this PR when you have some time?
If you're open to it, I’m planning to add the necessary tests as well.
Thank you in advance for your time and consideration!

@kahirokunn kahirokunn force-pushed the support-http-scaled-object branch 2 times, most recently from fbc0de0 to a10ce9d Compare December 12, 2024 00:38
@kahirokunn kahirokunn changed the title add support for KEDA HTTPScaledObjects via HTTPScaledObjectReconciler [WIP] add support for KEDA HTTPScaledObjects via HTTPScaledObjectReconciler Dec 12, 2024
@kahirokunn kahirokunn marked this pull request as draft December 17, 2024 03:33
- Fix spelling of AutoscalerReference (was AutoscalerRefernce) in type definition and struct field

Signed-off-by: kahirokunn <[email protected]>
This commit will be dropped when the review is complete.

Signed-off-by: kahirokunn <[email protected]>
…amespace Gateway API support

Signed-off-by: kahirokunn <[email protected]>
@kahirokunn kahirokunn force-pushed the support-http-scaled-object branch from a10ce9d to 87f2929 Compare December 17, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant