Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disableTLS option for webhooks request #1709

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

juparog
Copy link
Contributor

@juparog juparog commented Oct 4, 2024

Adding configurable disableTls option for webhooks.

This is useful in cases where the target service uses self-signed certificates, or you need to connect to an insecure service for testing purposes.

@juparog juparog requested a review from stefanprodan as a code owner October 4, 2024 00:04
@juparog
Copy link
Contributor Author

juparog commented Oct 7, 2024

Hi, @stefanprodan @aryan9600
I would like to know the release times in which this setting would come out if it were closed. Does it have only monthly release dates?

@aryan9600
Copy link
Member

yes, that's the typical release cadence.

@aryan9600 aryan9600 force-pushed the juparog/webhook-disabletls branch from 63226c3 to 3d2e0b4 Compare November 21, 2024 13:43
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.08%. Comparing base (b88e080) to head (8f83838).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/webhook.go 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
+ Coverage   35.06%   35.08%   +0.02%     
==========================================
  Files         283      283              
  Lines       24645    24653       +8     
==========================================
+ Hits         8642     8650       +8     
  Misses      15063    15063              
  Partials      940      940              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aryan9600 aryan9600 force-pushed the juparog/webhook-disabletls branch from 3d2e0b4 to 8f83838 Compare November 21, 2024 13:52
@stefanprodan stefanprodan changed the title feat: add disableTls option for webhooks request feat: add disableTLS option for webhooks request Nov 21, 2024
@juparog juparog closed this Nov 23, 2024
@juparog juparog reopened this Nov 23, 2024
@stefanprodan stefanprodan merged commit 2ba00a3 into fluxcd:main Nov 23, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants