Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for deploymentLabels #1707

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add support for deploymentLabels #1707

wants to merge 4 commits into from

Conversation

quintonm
Copy link

This PR adds support for configuring additional labels for the deployment using deploymentLabels in values.yaml.

aryan9600
aryan9600 reviewed Oct 6, 2024
View reviewed changes
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this PR! could you also update the chart's README accordingly. i see that we missed out on the docs for podLabels, so we can do both in this PR as well

@KrylixZA
Copy link

KrylixZA commented Oct 8, 2024

Could this be used to address the issues raised in #1312?

@aryan9600
Copy link
Member

@KrylixZA i'm investigating that. i'd say if that needs to be addressed, we shall do so in a different PR, since they're completely different things.

@quintonm
Copy link
Author

@aryan9600 README has been updated. Should I make a similar update to docs/gitbook/install/flagger-install-on-kubernetes.md?

@aryan9600
Copy link
Member

Sure, that'd be great. Could you also specify the podLabels and deploymentLabels values in the table in charts/flagger/README.md?

@quintonm
Copy link
Author

Sure, that'd be great. Could you also specify the podLabels and deploymentLabels values in the table in charts/flagger/README.md?

done

@quintonm
Copy link
Author

quintonm commented Dec 3, 2024

@aryan9600 Any other changes needed?

@quintonm
Copy link
Author

@aryan9600 @stefanprodan - Just following up on this PR. Are any other changes needed? Thanks for taking the time to review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryan9600 aryan9600 aryan9600 left review comments

@stefanprodan stefanprodan stefanprodan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quintonm @KrylixZA @aryan9600 @stefanprodan