Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: analytics webhook retries #1520

Closed

Conversation

Kwasniewski
Copy link
Contributor

Current situation

When we have an analytics webhook that failures we instantly increase the overall canary failure count.

Proposal

This PR adds in pre-webhook configuration for retries before increasing the failure count for the canary deployment.

If this option is not set, it will continue the current behavior of increasing the failure count.

This is trying to address issue #1501 and a slight more robust version of PR #1508

@Kwasniewski Kwasniewski force-pushed the rollout_webhook_retry_fixed branch from 3d8dd05 to de5cd1e Compare September 18, 2023 20:22
Signed-off-by: Joseph Kwasniewski <[email protected]>
Signed-off-by: Joseph Kwasniewski <[email protected]>
@Kwasniewski Kwasniewski force-pushed the rollout_webhook_retry_fixed branch from ce228dc to a5460ed Compare October 1, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant