Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support for queryParams in canary match condition #880 #1505

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

sonbui00
Copy link
Contributor

@sonbui00 sonbui00 commented Sep 5, 2023

Fix #880

Add queryParams in canary match

@sonbui00 sonbui00 marked this pull request as ready for review September 6, 2023 01:19
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @sonbui00

could you please rebase on top of main and force push?

@aryan9600 aryan9600 merged commit 8dbd8d5 into fluxcd:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for queryParams in canary match condition
2 participants