Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsing status.observedGeneration as string #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isugimpy
Copy link

@isugimpy isugimpy force-pushed the observed_generation_fix branch from e1a2e91 to 0a3f97a Compare February 27, 2024 17:48
@souleb
Copy link
Member

souleb commented Feb 27, 2024

I have checked and ObservedGeneration is always an int64 in upstream Kubernetes and I believe in most common crds. It would be best if ArgoRollouts would just fix this, I think.

@isugimpy
Copy link
Author

I agree, I've opened argoproj/argo-rollouts#3402 with them, but unfortunately I would anticipate that they're going to be unwilling to change it because this has been configured this way for 3 years. That said, this gives a little bit of safety wrapping their behavior and still allows things to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants