jobtap: add flux_jobtap_jobspec_update_id_pack()
#6500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: There's no interface to update the jobspec of a job outside of a jobtap callback for that job. Add flux_jobtap_jobspec_update_id_pack(). This function just does some nominal checks on the target job, then wraps event_post_pack().
Problem: The jobtap API call flux_jobtap_jobspec_update_id_pack() is not tested. Add it to the testing in t2212-job-manager-plugins.t.
|
Thanks! I'll set MWP. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6500 +/- ##
=======================================
Coverage 83.61% 83.62%
=======================================
Files 524 524
Lines 87623 87654 +31
=======================================
+ Hits 73267 73301 +34
+ Misses 14356 14353 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #5957 by adding a function that posts a
jobspec-updateevent for an arbitrary jobid.The function assumes the target job is not in an active callback, i.e. it is being updated asynchronously, so some of the work of
flux_jobtap_josbpec_update_pack(), like accumulating updates until the current callback is complete, can be skipped. Thus the function is really just a wrapper aroundevent_post_pack().