add flux.conf_builtin.conf_builtin_get() to give Python access to compiled-in config values
#6486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grondo
force-pushed
the
python-conf-builtin
branch
from
efe2f32 to
6b36221
Compare
grondo
force-pushed
the
python-conf-builtin
branch
from
6b36221 to
22fd013
Compare
|
Thanks! I'll set MWP. |
Problem: It would be useful to query the builtin intree or installed configuration path from libflux, but flux_conf_builtin_get() does not support that specific value. Add confdir to the list of supported keys for flux_conf_builtin_get().
Problem: Python programs do not have access to libflux builtin configuration values via flux_conf_builtin_get(). Add flux.conf_builtin.conf_builtin_get() which provides access to this function from Python. Unfortunately, the bahavior of FLUX_CONF_AUTO must be duplicated because the builtin libflux intree vs installed tests do not work when `python` is the executable (since it isn't part of Flux).
Problem: There are no unit tests for the Python interface to flux_conf_builtin_get(). Add some very simple tests.
grondo
force-pushed
the
python-conf-builtin
branch
from
22fd013 to
024e5cb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6486 +/- ##
==========================================
- Coverage 83.63% 83.61% -0.02%
==========================================
Files 524 525 +1
Lines 87654 87680 +26
==========================================
+ Hits 73309 73318 +9
- Misses 14345 14362 +17
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Python programs have no way to query libflux for compiled-in config values, but this could be useful if they want to find the current config directory. This could possibly be derived from broker attributes, but in some cases the broker attributes could be set to nothing, so this is not ideal.
Calling in to
flux_conf_builtin_get()withFLUX_CONF_AUTOusing ffi doesn't work, because the "executable" for Python programs is always going to be apythonbinary installed in the system (or elsewhere), so the libflux intree detection doesn't work.This PR introduces a wrapper for
flux_conf_builtin_get()for Python that reimplements intree detection using the path to module itself compared to the intree python_path.Since the motivating use case is to determine the current appropriate Flux confdir from a Python program, this PR also adds a new builtin config key
confdirfor this purpose.