-
-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(device_info_plus)!: Return model name for iOS and MacOS devices #3358
base: main
Are you sure you want to change the base?
Conversation
case "Mac14,5", "Mac14,9": return "MacBook Pro (14-inch, 2023)" | ||
case "Mac14,6", "Mac14,10": return "MacBook Pro (14-inch, 2023)" | ||
case "Mac14,7": return "MacBook Pro (13-inch, 2022)" | ||
case "Mac15,3": return "MacBook Pro (14-inch, 2023)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these lists I wasn't sure if we need to specify CPU model, like it is done on Apple's website but decided that it is redundant info.
Don't know why iOS integration test fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Could be that increasing the minimum deployment target makes these properties mandatory:
You can try to add a version here: https://github.com/fluttercommunity/plus_plugins/blob/main/packages/device_info_plus/device_info_plus/example/pubspec.yaml |
I saw these warnings earlier, but still tried to add version - still failing. Will investigate later. |
This feature is needed by many people, but the downside is that maintenance can be troublesome. After Apple releases new devices, we need to update the code promptly. Therefore, I suggest changing the "Unknown Model" returned in modelName to modelIdentifier. This would avoid situations where modelName == Unknown Model, and we might need to use modelIdentifier in conjunction with it to determine the device information accurately. |
This is not an issue with current pace of product releases from Apple. It is not a big deal to report the missing model. Returning |
Description
Long awaited feature to show device names that are known to users. Marking as breaking, because I changed the API.
On iOS
model
field now returns names likeiPhone 15 Pro
, etc. instead of justiPhone
,iPad
.Screenshot from iPhone with model name
On MacOS the plugin returns
modelName
andmodelIdentifier
fields instead of justmodel
which was returning identifier earlier.Screenshot from MacBook with model name and identifier
Related Issues
Closes #2656
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).